Skip to content

release-25.2: ui: move TimezoneProvider to be inside RequiredLogin#169783

Merged
trunk-io[bot] merged 1 commit into
cockroachdb:release-25.2from
kyle-a-wong:backport25.2-169751
May 18, 2026
Merged

release-25.2: ui: move TimezoneProvider to be inside RequiredLogin#169783
trunk-io[bot] merged 1 commit into
cockroachdb:release-25.2from
kyle-a-wong:backport25.2-169751

Conversation

@kyle-a-wong
Copy link
Copy Markdown
Contributor

Backport 1/1 commits from #169751 on behalf of @kyle-a-wong.

/cc @cockroachdb/release


Fixes a bug where the login page was making a request for cluster settings in order to create the timezone provider context. This request results in a 401 unauthorized since users need to be authorized to request cluster setting data. In version before 26.3, this bug made it impossible to login as a non default tenant via OIDC login, since this unauthorized response caused tenant cookies to be cleared before user could click the OIDC button.

Epic: None
Release note: None


Release justification: Fix for a bug that prevents non-default tenant OIDC login

@trunk-io
Copy link
Copy Markdown
Contributor

trunk-io Bot commented May 5, 2026

😎 Merged successfully - details.

@blathers-crl
Copy link
Copy Markdown

blathers-crl Bot commented May 5, 2026

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes OR fixes for serious issues. Non-production includes test-only changes, build system changes, etc. Serious issues are defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to. Reference the approved ENGREQ ticket in the PR body (e.g., "Fixes ENGREQ-123").

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl Bot added backport Label PR's that are backports to older release branches T-observability labels May 5, 2026
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Fixes a bug where the login page was making a request for
cluster settings in order to create the timezone provider
context. This request results in a 401 unauthorized since
users need to be authorized to request cluster setting
data. In version before 26.3, this bug made it impossible
to login as a non default tenant via OIDC login, since
this unauthorized response caused tenant cookies to
be cleared before user could click the OIDC button.

Epic: None
Release note: None
@kyle-a-wong kyle-a-wong force-pushed the backport25.2-169751 branch from 73d635f to a4f448a Compare May 15, 2026 19:06
@kyle-a-wong kyle-a-wong marked this pull request as ready for review May 15, 2026 19:06
@kyle-a-wong kyle-a-wong requested a review from a team as a code owner May 15, 2026 19:06
@kyle-a-wong kyle-a-wong requested review from dhartunian and removed request for a team May 15, 2026 19:06
@kyle-a-wong
Copy link
Copy Markdown
Contributor Author

/trunk merge

@trunk-io trunk-io Bot merged commit b251fd9 into cockroachdb:release-25.2 May 18, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches T-observability target-release-25.2.20

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants