sql/importer: cap metamorphic batch sizes in TestImportCSVStmt#170013
Conversation
The test has been timing out under metamorphic builds when `kv-batch-size` and `datum-row-converter-batch-size` are randomized to their minimum (1). With 18 subtests sharing one cluster, those values blow through the 15-minute package timeout. Override both to 10 in the test setup. Adds TestingRaiseDefaultKVBatchSize to pkg/sql/row since `kv-batch-size` had no testing setter; the existing TestingSetDatumRowConverterBatchSize covers the other. Local timing with both constants forced to 1 vs 10: 74.6s -> 28.2s. Fixes: cockroachdb#167087 Release note: None
|
😎 Merged successfully - details. |
|
Detected infrastructure failure (matched: self-hosted runner lost communication with the server). Automatically rerunning failed jobs. (run link) |
ZhouXing19
left a comment
There was a problem hiding this comment.
Nice, thanks!! LGTM.
|
TFTR! /trunk merge |
|
Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches. Issue #167087: branch-release-26.1, branch-release-26.2. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating backport branch refs/heads/blathers/backport-release-25.4-170013: POST https://api.github.com/repos/DrewKimball/cockroach/git/refs: 403 Resource not accessible by integration [] Backport to branch 25.4.x failed. See errors above. error creating backport branch refs/heads/blathers/backport-release-26.1-170013: POST https://api.github.com/repos/DrewKimball/cockroach/git/refs: 403 Resource not accessible by integration [] Backport to branch 26.1.x failed. See errors above. error creating backport branch refs/heads/blathers/backport-release-26.2-170013: POST https://api.github.com/repos/DrewKimball/cockroach/git/refs: 403 Resource not accessible by integration [] Backport to branch 26.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
The test has been timing out under metamorphic builds when
kv-batch-sizeanddatum-row-converter-batch-sizeare randomized to their minimum (1). With 18 subtests sharing one cluster, those values blow through the 15-minute package timeout.Override both to 10 in the test setup. Adds TestingRaiseDefaultKVBatchSize to pkg/sql/row since
kv-batch-sizehad no testing setter; the existing TestingSetDatumRowConverterBatchSize covers the other.Local timing with both constants forced to 1 vs 10: 74.6s -> 28.2s.
Fixes: #167087
Release note: None