sql: add descriptors.json and schema_changes.txt to stmtbundle#170622
Open
virajchogle wants to merge 1 commit into
Open
sql: add descriptors.json and schema_changes.txt to stmtbundle#170622virajchogle wants to merge 1 commit into
virajchogle wants to merge 1 commit into
Conversation
When investigating optimizer surprises, the bundle reviewer often needs to rule out schema-state interactions. Two new files help: descriptors.json with the pretty-printed JSON for each descriptor used by the statement, and schema_changes.txt with the recent schema-change job history for those descriptors. The declarative schema changer drains payload.DescriptorIDs as targets complete, so completed declarative jobs have an empty descriptorIds field. PrintSchemaChanges therefore also matches the descriptor's fully-qualified name against the job's description text. Fixes: cockroachdb#170491 Epic: None Release note (general change): Statement bundles produced by EXPLAIN ANALYZE (DEBUG) now include descriptors.json (pretty-printed descriptor JSON for each object used by the statement) and schema_changes.txt (recent schema-change history for those descriptors).
Contributor
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. I have added a few people who may be able to assist in reviewing: 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When investigating optimizer surprises, the bundle reviewer often needs to rule out schema-state interactions. Two new files help: descriptors.json with the pretty-printed JSON for each descriptor used by the statement, and schema_changes.txt with the recent schema-change job history for those descriptors.
The declarative schema changer drains payload.DescriptorIDs as targets complete, so completed declarative jobs have an empty descriptorIds field. PrintSchemaChanges therefore also matches the descriptor's fully-qualified name against the job's description text.
Verified manually on a single-node demo cluster:
Fixes: #170491
Epic: None
Release note (general change): Statement bundles produced by EXPLAIN ANALYZE (DEBUG) now include descriptors.json (pretty-printed descriptor JSON for each object used by the statement) and schema_changes.txt (recent schema-change history for those descriptors).
@michae2