staging-v24.3.33: release-24.3: kvserver: stop wrapping AbortSpan errors as ReplicaCorruptionError#170688
Merged
rail merged 1 commit intoMay 20, 2026
Conversation
This is the last remaining production call site that wraps errors as `ReplicaCorruptionError`. A failure to read from the AbortSpan is not indicative of replica corruption and should not crash the node. This is a minimal fix suitable for backporting. A follow-up commit removes the now-dead `ReplicaCorruptionError` infrastructure entirely. Informs: cockroachdb#165558 Release note (bug fix): Fixed a bug where transient I/O errors reading from the AbortSpan were misidentified as replica corruption, causing the node to crash. These errors are now returned to the caller as regular errors. Epic: none Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Thanks for opening a backport. Before merging, please confirm that it falls into one of the following categories (select one):
Add a brief release justification to the PR description explaining your selection. Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy. All backports must be reviewed by the TL and EM for the owning area. |
blathers-crl
Bot
added
backport
Member
|
This change is |
rickystewart
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #168856.
/cc @cockroachdb/release
Backport 1/2 commits from #167295.
/cc @cockroachdb/release
AbortSpan read errors were wrapped as
ReplicaCorruptionError, causing thenode to fatal via
setCorruptRaftMuLocked. This was overly aggressive: afailure to read from the AbortSpan is not indicative of replica corruption.
Transient I/O errors would crash the node instead of being returned to the
caller.
This is the last remaining production call site that produces
ReplicaCorruptionError(the split/merge trigger wrapping was removed in#167289).
Informs: #165558
Epic: none
Release justification: Low-risk bug fix. One-line change that stops wrapping
a non-corruption error as
ReplicaCorruptionError, preventing unnecessarynode crashes on transient I/O errors during AbortSpan reads.
Release justification: