release-26.1: kvcoord: deflake TestTxnCoordSenderRetriesAcrossEndTxn#170929
Merged
trunk-io[bot] merged 1 commit intoMay 26, 2026
Conversation
The first subtest asserted ExpectPusheeTxnRecordNotFound, which requires the push to find no txn record at all. However, the heartbeat loop can race and write a PENDING txn record during CommitInBatch execution, causing the push to find that record and fail the assertion. Replace with the new ExpectNoTxnRecovery expectation, which verifies the actual invariant: no STAGING record was found and no transaction recovery was performed. This tolerates a PENDING record from the heartbeat loop while still checking that the txn was not implicitly committed. Fixes: #170829 Release note: None Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
blathers-crl
Bot
force-pushed
the
blathers/backport-release-26.1-170836
branch
from
b97373e to
5fb9f4e
Compare
blathers-crl
Bot
added
blathers-backport
Author
|
Thanks for opening a backport. Before merging, please confirm that the change does not break backwards compatibility and otherwise complies with the backport policy. Include a brief release justification in the PR description explaining why the backport is appropriate. All backports must be reviewed by the TL for the owning area. While the stricter LTS policy does not yet apply, please exercise judgment and consider gating non-critical changes behind a disabled-by-default feature flag when appropriate. |
Contributor
|
😎 Merged successfully - details. |
blathers-crl
Bot
added
backport
Member
|
This change is |
arulajmani
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #170836 on behalf of @pav-kv.
The first subtest asserted
ExpectPusheeTxnRecordNotFound, which requires the push to find no txn record at all. However, the heartbeat loop can race and write aPENDINGtxn record duringCommitInBatchexecution, causing the push to find that record and fail the assertion.Replace with the new
ExpectNoTxnRecoveryexpectation, which verifies the actual invariant: noSTAGINGrecord was found and no transaction recovery was performed. This tolerates aPENDINGrecord from the heartbeat loop while still checking that the txn was not implicitly committed.Fixes-25.4 #170829
Epic: none
Release justification: test deflake