Skip to content

release-25.4: workload: reduce yscb setup batch size#170957

Merged
trunk-io[bot] merged 1 commit into
release-25.4from
blathers/backport-release-25.4-170934
May 26, 2026
Merged

release-25.4: workload: reduce yscb setup batch size#170957
trunk-io[bot] merged 1 commit into
release-25.4from
blathers/backport-release-25.4-170934

Conversation

@blathers-crl
Copy link
Copy Markdown

@blathers-crl blathers-crl Bot commented May 26, 2026

Backport 1/1 commits from #170934 on behalf of @golgeek.


TestAllRegisteredSetup/ycsb can run under an external-process test tenant. YCSB's default setup path uses 1000-row INSERT batches, and because YCSB places each field in its own column family, each batch fans out to a large number of KV writes.

In overloaded CI runs, that can starve SQL liveness heartbeats long enough for the tenant to shut down, surfacing as setup failures such as "sql: database is closed".

Cap only the YCSB InsertsDataLoader batch size in TestAllRegisteredSetup. This keeps the test exercising the same workload and tenant mode while reducing the size of each setup write batch. This does not change YCSB workload defaults or benchmark/import behavior outside this test.

Epic: none
Fixes: #170911, #169034, #168946
Release note: None


Release justification: test only change

`TestAllRegisteredSetup/ycsb` can run under an external-process test
tenant. YCSB's default setup path uses 1000-row `INSERT` batches,
and because YCSB places each field in its own column family,
each batch fans out to a large number of KV writes.

In overloaded CI runs, that can starve SQL liveness heartbeats long enough
for the tenant to shut down, surfacing as setup failures such as
"sql: database is closed".

Cap only the YCSB `InsertsDataLoader` batch size in `TestAllRegisteredSetup`.
This keeps the test exercising the same workload and tenant mode while
reducing the size of each setup write batch. This does not change YCSB
workload defaults or benchmark/import behavior outside this test.

Epic: none
Fixes: #170911, #169034, #168946
Release note: None
@blathers-crl blathers-crl Bot requested a review from a team as a code owner May 26, 2026 21:30
@blathers-crl blathers-crl Bot requested review from cpj2195 and shailendra-patel and removed request for a team May 26, 2026 21:30
@blathers-crl
Copy link
Copy Markdown
Author

blathers-crl Bot commented May 26, 2026

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes OR fixes for serious issues. Non-production includes test-only changes, build system changes, etc. Serious issues are defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to. Reference the approved ENGREQ ticket in the PR body (e.g., "Fixes ENGREQ-123").

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@trunk-io
Copy link
Copy Markdown
Contributor

trunk-io Bot commented May 26, 2026

😎 Merged directly without going through the merge queue, as the queue was empty and the PR was up to date with the target branch - details.

@blathers-crl blathers-crl Bot added backport Label PR's that are backports to older release branches T-testeng TestEng Team O-robot Originated from a bot. blathers-backport This is a backport that Blathers created automatically. labels May 26, 2026
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@blathers-crl blathers-crl Bot added the backport-test-only Used to denote the backport has only non-production changes label May 26, 2026
@golgeek
Copy link
Copy Markdown
Contributor

golgeek commented May 26, 2026

/trunk merge

@trunk-io trunk-io Bot merged commit 574f3d8 into release-25.4 May 26, 2026
21 checks passed
@trunk-io trunk-io Bot deleted the blathers/backport-release-25.4-170934 branch May 26, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches backport-test-only Used to denote the backport has only non-production changes blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. T-testeng TestEng Team target-release-25.4.11

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants