RFC for stateless replica relocation.#2171
Merged
mrtracy merged 1 commit intocockroachdb:masterfrom Aug 24, 2015
Merged
Conversation
Contributor
There was a problem hiding this comment.
I think this is complicated enough that it probably makes sense to put all these RFCs into one design doc. I'd suggest writing a design doc about maintaining ideal replication, and keep adding to it as you develop the system
Contributor
There was a problem hiding this comment.
I'd also add a section in that design doc about the replication queue.
Contributor
|
LGTM. I agree with the stateless design. We should only introduce state here if we really need it, and I don't think we do. |
Contributor
There was a problem hiding this comment.
inconsistent use of double spaces abound
Contributor
|
LGTM |
1 similar comment
Member
|
LGTM |
620c5b5 to
901c4ae
Compare
[ci skip]
901c4ae to
bd7c67d
Compare
mrtracy
added a commit
that referenced
this pull request
Aug 24, 2015
RFC for stateless replica relocation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.