Skip to content

RFC for stateless replica relocation.#2171

Merged
mrtracy merged 1 commit intocockroachdb:masterfrom
mrtracy:mtracy-rfcs-stateless-relocate
Aug 24, 2015
Merged

RFC for stateless replica relocation.#2171
mrtracy merged 1 commit intocockroachdb:masterfrom
mrtracy:mtracy-rfcs-stateless-relocate

Conversation

@mrtracy
Copy link
Copy Markdown
Contributor

@mrtracy mrtracy commented Aug 19, 2015

No description provided.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is complicated enough that it probably makes sense to put all these RFCs into one design doc. I'd suggest writing a design doc about maintaining ideal replication, and keep adding to it as you develop the system

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also add a section in that design doc about the replication queue.

@bdarnell
Copy link
Copy Markdown
Contributor

LGTM. I agree with the stateless design. We should only introduce state here if we really need it, and I don't think we do.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inconsistent use of double spaces abound

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed throughout.

@tamird
Copy link
Copy Markdown
Contributor

tamird commented Aug 20, 2015

LGTM

1 similar comment
@BramGruneir
Copy link
Copy Markdown
Member

LGTM

@mrtracy mrtracy force-pushed the mtracy-rfcs-stateless-relocate branch from 620c5b5 to 901c4ae Compare August 20, 2015 19:37
@mrtracy mrtracy force-pushed the mtracy-rfcs-stateless-relocate branch from 901c4ae to bd7c67d Compare August 24, 2015 21:00
mrtracy added a commit that referenced this pull request Aug 24, 2015
@mrtracy mrtracy merged commit 7dad074 into cockroachdb:master Aug 24, 2015
@mrtracy mrtracy deleted the mtracy-rfcs-stateless-relocate branch August 24, 2015 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants