Add downreplication to Replicate queue#2350
Merged
mrtracy merged 1 commit intocockroachdb:masterfrom Sep 4, 2015
Merged
Conversation
mrtracy
force-pushed
the
mtracy/replicate_queue_enhance
branch
from
7a3fc4e to
1a81f28
Compare
Contributor
There was a problem hiding this comment.
I would call this store0 (use index in the stores array instead of the store ID). Neither way is ideal, but I've found it's less confusing overall to use the index in the test code, since that's what you have to pass to methods like replicateRange.
Contributor
|
LGTM |
The Replicate Queue can now remove replicas from a range that is over-replicated.
mrtracy
force-pushed
the
mtracy/replicate_queue_enhance
branch
from
1a81f28 to
04ab5c0
Compare
Contributor
Author
|
I believe I found and fixed the rare failure that was occurring in the test on Thursday. |
Member
|
LGTM besides the priority part. (And if you really think that it's not needed, than go ahead without it. But I do think it is important.) |
mrtracy
added a commit
that referenced
this pull request
Sep 4, 2015
Add downreplication to Replicate queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Replicate Queue can now remove replicas from a range that is
over-replicated.