Makefile: support building libkrb5 with musl on Linux#38429
Open
benesch wants to merge 1 commit intocockroachdb:masterfrom
Open
Makefile: support building libkrb5 with musl on Linux#38429benesch wants to merge 1 commit intocockroachdb:masterfrom
benesch wants to merge 1 commit intocockroachdb:masterfrom
Conversation
Linking libkrb5 requires that cgo passes -static while linking intermediate artifacts. This was previously impossible due to a bug in the Go toolchain (golang/go#16651), which has now been resolved. Remove our workaround for this issue, and enable building/linking libkrb5 when building with musl on Linux. Release note: None
Member
|
This change is |
madelynnblue
approved these changes
Jun 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed this while working on #32623 and couldn't resist. I manually ran
mkrelease {linux-gnu,linux-musl,darwin,windows}to verify this doesn't cause build regressions.Linking libkrb5 requires that cgo passes -static while linking
intermediate artifacts. This was previously impossible due to a
bug in the Go toolchain (golang/go#16651), which has now been
resolved. Remove our workaround for this issue, and enable
building/linking libkrb5 when building with musl on Linux.
Release note: None