config: validate that subzones have fields in tandem#39995
Open
ridwanmsharif wants to merge 1 commit intocockroachdb:masterfrom
Open
config: validate that subzones have fields in tandem#39995ridwanmsharif wants to merge 1 commit intocockroachdb:masterfrom
ridwanmsharif wants to merge 1 commit intocockroachdb:masterfrom
Conversation
Fixes cockroachdb#39994. Previously we only validated the zone we were writing but when we're writing index or partition zones, we write a subzone inside another zone. Instead of validating this subzone, we we're incorrectly validating the parent zone. This change rectifies that. Release note: None
Member
|
This change is |
andreimatei
reviewed
Aug 27, 2019
Contributor
andreimatei
left a comment
andreimatei
left a comment
There was a problem hiding this comment.
@solongordon this conflicts with stuff you've just merged in a non-trivial way. Would you mind taking this over?
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @andreimatei)
Contributor
|
@ridwanmsharif, this commit really needs a release note text. Otherwise, we (docs) won't catch wind of it. And there are places in the docs that we need to touch. |
Contributor
|
@solongordon, if you're taking over this PR, please see my note above about needing a release note text. |
craig bot
pushed a commit
that referenced
this pull request
Oct 3, 2019
41216: Config: validate that subzones have fields in tandem r=solongordon a=rohany Previously we only validated the zone we were writing but when we're writing index or partition zones, we write a subzone inside another zone. Instead of validating this subzone, we we're incorrectly validating the parent zone. This change rectifies that. Change courtesy of @ridwanmsharif. This change basically rebases ridwan's changes in #39995 and removes some semicolons in the logic tests. Fixes #39994. Release justification: low risk bug fix Release note (bug fix): Fix bug where zone configuration changes on secondary indexes wouldn't perform setting verification (such as constraints with lease preferences, or setting only one of min_range_size and max_range size). Co-authored-by: Rohan Yadav <rohany@cockroachlabs.com>
Member
|
Ridwan Sharif seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39994.
Previously we only validated the zone we were writing
but when we're writing index or partition zones, we write
a subzone inside another zone. Instead of validating this
subzone, we we're incorrectly validating the parent zone.
This change rectifies that.
Release note: None
cc @andreimatei I'll be losing bors access and might not be
able to continue working on this soon. Going to punt this over
to you to triage if that happens 😀