sql: clarify the handling of the first message in a remote DistSQL st…#41454
Open
andreimatei wants to merge 1 commit intocockroachdb:masterfrom
Open
sql: clarify the handling of the first message in a remote DistSQL st…#41454andreimatei wants to merge 1 commit intocockroachdb:masterfrom
andreimatei wants to merge 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
RaduBerinde
reviewed
Oct 10, 2019
Member
RaduBerinde
left a comment
RaduBerinde
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @andreimatei and @RaduBerinde)
pkg/sql/flowinfra/inbound.go, line 74 at r1 (raw file):
ctx context.Context, stream execinfrapb.DistSQL_FlowStreamServer, firstMsg execinfrapb.ProducerMessage,
Isn't this pretty big to be put on the stack?
…ream The first message in a stream is special; it includes a header specifying whose the destination is, so it needs to be decoded before handing it to the usual stream handling machinery. The row-based handler was guarding unnecessarily for the case where it's not handed such a first message. This commits removes this guard and clarifies that you always have such a message. Touches cockroachdb#41456 Release note: None
andreimatei
force-pushed
the
distsql.first-msg
branch
from
d3893a1 to
df020c4
Compare
andreimatei
commented
Jan 2, 2020
Contributor
Author
andreimatei
left a comment
andreimatei
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/sql/flowinfra/inbound.go, line 74 at r1 (raw file):
Previously, RaduBerinde wrote…
Isn't this pretty big to be put on the stack?
ok, passed by ptr again
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ream
The first message in a stream is special; it includes a header
specifying whose the destination is, so it needs to be decoded before
handing it to the usual stream handling machinery. The row-based handler was
guarding unnecessarily for the case where it's not handed such a first
message. This commits removes this guard and clarifies that you always
have such a message.
Touches #41456
Release note: None