[DNM] changefeedccl: implement gocloud.dev/pubsub sink#43084
Draft
ajwerner wants to merge 1 commit intocockroachdb:masterfrom
Draft
[DNM] changefeedccl: implement gocloud.dev/pubsub sink#43084ajwerner wants to merge 1 commit intocockroachdb:masterfrom
ajwerner wants to merge 1 commit intocockroachdb:masterfrom
Conversation
This is a WIP PR to implement a changefeed sink for the generic pubsub API exposed by gocloud.dev/pubsub. It does not currently deal with lack of ordering for the nemesis test. Fixes cockroachdb#36982. Release note (enterprise change): Add support for gcp pubsub as a CHANGEFEED sink.
Member
|
This change is |
|
Any chance to push this forward @mwang1026? Would love to see this landing on the next release! /cc @lopezator |
|
I don't think this will make 20.2 (this October) but it's a strong consideration for 21.1 (next April). We'll update this thread when we have something more concrete and would love to include you as design partners! |
|
xrefing a comment I just made in the issue about ordering guarantees google is providing with pubsub: #36982 (comment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very WIP PR to implement a changefeed sink for the generic pubsub API
exposed by gocloud.dev/pubsub. It does not currently deal with lack of ordering
for the nemesis test.
Fixes #36982.
Release note (enterprise change): Add support for gcp pubsub as a CHANGEFEED
sink.