Skip to content

changefeedccl: transfer todos from aayush to dan/ajwerner#43380

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
aayushshah15:changefeed_comment_cleanup
Dec 20, 2019
Merged

changefeedccl: transfer todos from aayush to dan/ajwerner#43380
craig[bot] merged 1 commit intocockroachdb:masterfrom
aayushshah15:changefeed_comment_cleanup

Conversation

@aayushshah15
Copy link
Copy Markdown
Contributor

Transferring my TODOs to dan/ajwerner before I leave.

Release note: None

Transferring my TODOs to dan/ajwerner before I leave.

Release note: None
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @danhhz)

@aayushshah15
Copy link
Copy Markdown
Contributor Author

bors r+

craig Bot pushed a commit that referenced this pull request Dec 20, 2019
42203: roachtest: add tpccbench style workload to measure throughput while sustaining an avg latency threshold. r=aayushshah15 a=aayushshah15

This PR adds a new benchmarking workload that can be used to measure max
throughput on the `kv` workload (under various distributions) that be
sustained while maintaining an avg latency lower than a configured
threshold.

This tool was primarily written in order to demonstrate the performance
characteristics of hash sharded indexes under write-heavy sequential
worklaods, which would, in the absence of a hash sharded index, cause
a hotspot on a single range (and consequently, a single node).

Release note: None

43380: changefeedccl: transfer todos from aayush to dan/ajwerner r=aayushshah15 a=aayushshah15

Transferring my TODOs to dan/ajwerner before I leave.

Release note: None

Co-authored-by: Aayush Shah <aayush.shah15@gmail.com>
@craig
Copy link
Copy Markdown
Contributor

craig Bot commented Dec 20, 2019

Build succeeded

@craig craig Bot merged commit 19bf9ac into cockroachdb:master Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants