Open
Conversation
This removes the liveness probes from our K8s configs. In cockroachdb#44832, we mostly reached an agreement that the liveness probe is doing more harm than good. There is still some disagreement about whether other failure conditions, such as disk stalls, are better served by having CockroachDB detect them itself or by detecting them in a separate process responsible for running the liveness probe. Either way, that is not what the current liveness probe is doing. The readiness probe has been left as-is for now. Release note: None
Member
|
This change is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the liveness probes from our K8s configs. In #44832, we mostly
reached an agreement that the liveness probe is doing more harm than good.
There is still some disagreement about whether other failure conditions, such
as disk stalls, are better served by having CockroachDB detect them itself or
by detecting them in a separate process responsible for running the liveness
probe. Either way, that is not what the current liveness probe is doing.
The readiness probe has been left as-is for now.
Release note: None