sql: sort rows in pg_depends logictest#76125
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Feb 7, 2022
Merged
Conversation
This sorts on more columns in a logictest to ensure that the results are a bit more stable. While we could use the logictest `rowsort` option, this test already had an ORDER BY clause. Fixes cockroachdb#76124 Release note: None
Member
|
This change is |
ajwerner
approved these changes
Feb 7, 2022
Contributor
ajwerner
left a comment
ajwerner
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @stevendanna)
Collaborator
Author
|
bors r=ajwerner |
Contributor
|
Build succeeded: |
This was referenced Feb 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sorts on more columns in a logictest to ensure that the results
are a bit more stable. While we could use the logictest
rowsortoption, this test already had an ORDER BY clause.
Fixes #76124
Release note: None