sql: change when txn is checked refresh materialized views

[e-mbrown]

Due to the transaction being checked during planning
and not during execution, refresh materialized views
would fail from the client. Now the transaction is checked
during execution .

Release justification: Bug fix for refresh materialized views

Release note: None

[cockroach-teamcity]

This change is 

[rafiss]

can you add a test in materialized_view_test.go

right below

cockroach/pkg/sql/materialized_view_test.go

Line 70 in 9911916

}

you can add

	// Verify that refreshing with a prepared statement works.
	preparedStmt, err := sqlDB.Prepare(`REFRESH MATERIALIZED VIEW t.v;`)
	if err != nil {
		t.Fatal(err)
	}
	if _, err := preparedStmt.Exec(); err != nil {
		t.Fatal(err)
	}

[e-mbrown]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @rafiss)

---

pkg/sql/refresh_materialized_view.go line 82 at r1 (raw file):

Previously, rafiss (Rafi Shamim) wrote…

can you add a test in materialized_view_test.go

right below

cockroach/pkg/sql/materialized_view_test.go

Line 70 in 9911916

}

you can add

	// Verify that refreshing with a prepared statement works.
	preparedStmt, err := sqlDB.Prepare(`REFRESH MATERIALIZED VIEW t.v;`)
	if err != nil {
		t.Fatal(err)
	}
	if _, err := preparedStmt.Exec(); err != nil {
		t.Fatal(err)
	}

Done.

[rafiss]

lgtm!

[rafiss]

let's make sure this gets backported

[e-mbrown]

bors r=rafiss

[craig]

Build failed (retrying...):

• Bazel Essential CI (Cockroach)

[craig]

Build succeeded:

• Bazel Essential CI (Cockroach)

[blathers-crl]

Encountered an error creating backports. Some common things that can go wrong:

1. The backport branch might have already existed.
2. There was a merge conflict.
3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

---

error creating merge commit from fcf22cd to blathers/backport-release-22.1-87271: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.1.x failed. See errors above.

---

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.}