server: mark testDrainContext assertion methods as test helpers#87431
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Sep 6, 2022
Merged
server: mark testDrainContext assertion methods as test helpers#87431craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
The error messages in cases like cockroachdb#86974 are not useful otherwise. This change allows us to see where the assertion method was called from. Release justification: testing only.
Member
|
This change is |
knz
approved these changes
Sep 6, 2022
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error messages in cases like #86974 are not useful otherwise. This change allows us to see where the assertion method was called from.
Release justification: testing only.