Skip to content

Conversation

@blathers-crl
Copy link

@blathers-crl blathers-crl bot commented Mar 27, 2023

Backport 2/2 commits from #99643 on behalf of @tbg.

/cc @cockroachdb/release


This reverts #98150 because we think it introduced a problem that was detected
via the replicate/wide roachtest1. It seems that for reasons still unknown
we do rely on the periodic gossip trigger on liveness lease extensions.

Touches #99268.
Touches #97966.
Closes #99268.
Touches #98945.

Tracked in #99652.

Epic: none
Release note: None


Release justification: critical bug fix.

Footnotes

  1. roachtest: replicate/wide failed #99268 (comment)

tbg added 2 commits March 27, 2023 12:24
This reverts #98150 because we think it introduced a problem that was detected
via the `replicate/wide` roachtest[^1]. It seems that for reasons still unknown
we do rely on the periodic gossip trigger on liveness lease extensions.

[^1]: #99268 (comment)

Touches #99268.
Touches #97966.
Closes #99268.
Touches #98945.

Epic: none
Release note: None
Epic: none
Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner March 27, 2023 15:49
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-99643 branch 2 times, most recently from 89a4e20 to b40d939 Compare March 27, 2023 15:49
@blathers-crl blathers-crl bot requested review from erikgrinaker and nvb March 27, 2023 15:50
@blathers-crl
Copy link
Author

blathers-crl bot commented Mar 27, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Mar 27, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented Mar 27, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@nvb nvb merged commit da6663e into release-22.2 Mar 27, 2023
@nvb nvb deleted the blathers/backport-release-22.2-99643 branch March 27, 2023 18:35
celiala pushed a commit that referenced this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants