release-22.2: kvserver: revert #98150 #99673
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2/2 commits from #99643 on behalf of @tbg.
/cc @cockroachdb/release
This reverts #98150 because we think it introduced a problem that was detected
via the
replicate/wideroachtest1. It seems that for reasons still unknownwe do rely on the periodic gossip trigger on liveness lease extensions.
Touches #99268.
Touches #97966.
Closes #99268.
Touches #98945.
Tracked in #99652.
Epic: none
Release note: None
Release justification: critical bug fix.
Footnotes
roachtest: replicate/wide failed #99268 (comment) ↩