review: frame.go vocabulary order; ruff format - #131
Merged
Conversation
Vocabulary types cluster ahead of the type that consumes them; pure move, sorted lines identical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two mechanical tail items from the hygiene round:
protocol/wire/frame.go:GitFileStatusmoves ahead ofGitStatusResult, the type that carries it (vocabulary type ahead of its consumer). Pure move: sorted lines are identical.sdk/python:ruff formatover the eight files that were red on main; no semantic change.Gates:
asl ./...on both GOOS,go vet,go test -raceforprotocol/wire;ruff format --check,ruff check,pytest(155 passed) for the Python SDK.