Skip to content

perf(silkd): memchr the session sentinel scan (~26x) #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CMGS merged 1 commit into from
Jul 9, 2026
+3 −8
Merged

perf(silkd): memchr the session sentinel scan (~26x) #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions silkd/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions silkd/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ publish = false
[dependencies]
base64 = "0.22"
libc = "0.2"
memchr = "2"
notify = "6"
regex = "1"
serde = { version = "1", features = ["derive"] }
Expand Down
9 changes: 1 addition & 8 deletions silkd/src/session.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ impl Io {
return Err(io::Error::new(io::ErrorKind::UnexpectedEof, "shell exited"));
}
acc.extend_from_slice(&buf[..n]);
if let Some(pos) = find(&acc, mb) {
if let Some(pos) = memchr::memmem::find(&acc, mb) {
emit(&mut out, &mut frame, &acc[..pos]).await;
let mut rest = acc[pos + mb.len()..].to_vec();
while !rest.contains(&b'\n') && rest.len() < EXIT_TAIL_MAX {
Expand Down Expand Up @@ -304,13 +304,6 @@ async fn emit<W: AsyncWrite + Unpin>(out: &mut Option<&mut W>, frame: &mut Vec<u
}
}

fn find(haystack: &[u8], needle: &[u8]) -> Option<usize> {
if needle.is_empty() || haystack.len() < needle.len() {
return None;
}
haystack.windows(needle.len()).position(|w| w == needle)
}

/// POSIX single-quote quoting: wrap in '…', closing/reopening around any
/// embedded single quote.
fn shell_quote(s: &str) -> String {
Expand Down