fix(postclone): raise the fresh-DHCP-lease budget 15s -> 45s#28
Merged
Conversation
markReadyAfterIP flips a clone to lifecycle=failed when its fresh DHCP lease doesn't land within the budget. On-demand fork/restore clones fault RAM in lazily over UFFD and, with replicas>1, resume concurrently, so the first lease routinely landed just past 15s — turning healthy fork sub-agents Failed and triggering an operator rebuild (the transient sticky-Failed recover loop). 45s absorbs the slow-lease window; a genuinely dead VM still fails, just later.
Lead with the identifier and stop baking the 15s/45s magnitudes into prose so the constant stays the single source of truth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
markReadyAfterIP(the ready-gate from #23) flips a clone tolifecycle=failedwhen its fresh DHCP lease doesn't land within the budget. On-demand fork/restore clones fault RAM in lazily over UFFD and, withreplicas>1, resume concurrently — the first lease routinely landed just past 15s, turning healthy fork sub-agents Failed and triggering an operator sub-agent rebuild (a transient sticky-Failed → recreate → recover loop). 45s absorbs the slow-lease window; a genuinely dead VM still fails, just later.Root-caused via a multi-agent investigation of the observed fork transient-Failed.