Skip to content

Disabling AI auto-dub feature and forcing the original audio track#2957

Merged
ImprovedTube merged 4 commits intocode-charity:masterfrom
wbalbo:feat-original-audio-track
May 25, 2025
Merged

Disabling AI auto-dub feature and forcing the original audio track#2957
ImprovedTube merged 4 commits intocode-charity:masterfrom
wbalbo:feat-original-audio-track

Conversation

@wbalbo
Copy link
Contributor

@wbalbo wbalbo commented May 24, 2025

This PR should solve a lot of issues, mentioning the same problem, of having AI auto-dub the videos. The code should force the original audio track. I found all these: #2503, #2716, #2843, #2897; #2613, #2865

Took some time to do, I tested with all videos used as samples on #2716, and also with a lot of videos from my subs list.

I had to cover a lot of different scenarios. YouTube always keeps changing things, so for some videos I had to check some things, for others other things, but this code should cover most, if not all, of the scenarios, but if not, let me know.

Tested on both Chrome and Edge, as usual.

@wbalbo wbalbo requested a review from ImprovedTube May 24, 2025 19:12
@wbalbo wbalbo self-assigned this May 24, 2025
ImprovedTube.expandDescription();
setTimeout(function () {ImprovedTube.forcedTheaterMode(); }, 150);
if (location.href.indexOf('/embed/') === -1) { ImprovedTube.miniPlayer(); }
if (ImprovedTube.storage.disable_auto_dubbing === true) { ImprovedTube.disableAutoDubbing(); }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I forgot to add this

@ImprovedTube ImprovedTube added untested please test. (also applies to proactively merged pull requests.) important Critical or common. Thus to prioritize labels May 25, 2025
@ImprovedTube ImprovedTube merged commit 85af0e4 into code-charity:master May 25, 2025
1 check passed
@ImprovedTube
Copy link
Member

ImprovedTube commented May 25, 2025

now that you were at it (unlike anybody else), you might like / feel efficient to have a (quick) look at our subtitle features /my "contextual comment" in 2843 (Just another truism: The larger our collection gets, the more features could be combined well in some way or just displayed as neighboring toggles or anything)

@wbalbo
Copy link
Contributor Author

wbalbo commented May 25, 2025

now that you were at it (unlike anybody else), you might like / feel efficient to have a (quick) look at our subtitle features /my "contextual comment" in 2843 (Just another truism: The larger our collection gets, the more features could be combined / merged well in some way.)

Yep, I saw this comment and the sheet. Maybe to make it clear, you can create something like a feature request with all necessary details? Like a task so anyone (not only me) can get and start to work on this?

I noticed a lot of useful feature requests "hidden" in a lot of issues for other stuff.

@ImprovedTube
Copy link
Member

ImprovedTube commented May 25, 2025

@wbalbo yes 😄; another filter: "- [x]" in:body label:"List of tasks" sort:comments-desc
including #1445 #1451 #2111 (what to do for 1445 besides referring to it in 100 other threads? 😆 )

(Seems github stopped to show the progess-bar? (at /issues, of how many items of each list are done))

@wbalbo
Copy link
Contributor Author

wbalbo commented May 25, 2025

@wbalbo yes 😄; another filter: "- [x]" in:body label:"List of tasks" sort:comments-desc including #1445 #1451 #2111 (what to do for 1445 besides referring to it in 100 other threads? 😆 )

(Seems github stopped to show progess? (at /issues, of how many items of each list are re done))

Yeah, is easy to get confused sometimes.

I will check the list later and see if I can help with something.

@ImprovedTube
Copy link
Member

@wbalbo yes, it's just meant to prepare efficient work.
I regret this feburary 11th i couldn't find the signup link for Google Summer of code,
(Which offers volunteers $3000 or so), but of course there is more to try before 2026.

@wbalbo
Copy link
Contributor Author

wbalbo commented May 25, 2025

@wbalbo yes, it's just meant to prepare efficient work. I regret this feburary 11th i couldn't find the signup link for Google Summer of code, (Which offers volunteers $3000 or so), but of course there is more to try before 2026.

Yeah, sure. Did you think of adding a Sponsors option on the project's repository? Not sure if is possible to add for repos or in this case should be only for the creator.

Could help. I know that you already have a BTC donation link, but not everyone uses cryptocurrency.

@ImprovedTube
Copy link
Member

Yes, while https://github.com/sindresorhus/awesome has more traffic, even our readme alone could find a proper sponsor by now to finance some bounties. (And even when I dont believe in external links/ads in the header of pages. (The end of pages is a more destinct opportunity for sponsors with more than a spam mentality))

@wbalbo
Copy link
Contributor Author

wbalbo commented May 25, 2025

Yes, while https://github.com/sindresorhus/awesome has more traffic, even our readme alone could find a proper sponsor by now to finance some bounties. (And even when I dont believe in external links/ads in the header of pages. (The end of pages is a more destinct opportunity for sponsors with more than a spam mentality))

I would happily accept any bounty for some features that are possible to do (I already saw some that are literally impossible), but anyway, I would help anyway since this extension is also very useful to me.

@ImprovedTube
Copy link
Member

which? 😅 please add a new label #impossible(?)

Just hope in future, we'll have more framework (technically, financially, socially) to crowd-source "uBlock rules" and to team up with userscript & extension developers. Did you know https://github.com/JustOff/ca-archive ?

@wbalbo
Copy link
Contributor Author

wbalbo commented May 28, 2025

which? 😅 please add a new label #impossible(?)

Just hope in future, we'll have more framework (technically, financially, socially) to crowd-source "uBlock rules" and to team up with userscript & extension developers. Did you know https://github.com/JustOff/ca-archive ?

I guess this is an example: #2499

I saw others but if I find them again I will put the label.

Also didn't knew about this Classic Add-ons Archive, nice idea to have in some place this old extensions.

@ImprovedTube
Copy link
Member

@wbalbo oh you mean #2499 was frustratingly lengthy?
/ Unclear why it remained for Corruptinglyneedful, (through the feature live chat: collapsed?). I added the label Riddle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

important Critical or common. Thus to prioritize untested please test. (also applies to proactively merged pull requests.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants