Resolve type errors flagged by Dialyzer #1375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Not sure what to make of the build timing out. Is there anything I can do to resolve this? |
Contributor
Author
|
@begedin @joshsmith Any ideas as to what I can do to get the build passing? |
Contributor
|
Hey @landongrindheim Sorry for the delayed response. It looks like a build dependency has a bug. We're working on resolving it and it will hopefully get done today. |
begedin
force-pushed
the
develop
branch
18 times, most recently
from
e075407 to
6d6cc63
Compare
Contributor
|
@landongrindheim If you rebase off of develop now, the build should pass |
landongrindheim
force-pushed
the
1369-fix-dialyzer-errors
branch
from
caad45d to
c803a1c
Compare
Contributor
Author
|
@begedin rebased and pushed 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes type specs that were being flagged by Dialyzer
References
Closes #1369