Skip to content

Resolve type errors flagged by Dialyzer #1375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
begedin merged 1 commit into from
Feb 14, 2018
Merged

Resolve type errors flagged by Dialyzer #1375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/code_corps/emails/message_initiated_by_project_email.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ defmodule CodeCorps.Emails.MessageInitiatedByProjectEmail do
WebClient
}

@spec create(User.t, String.t) :: Bamboo.Email.t
@spec create(Message.t, Conversation.t) :: Bamboo.Email.t
def create(
%Message{project: %Project{} = project},
%Conversation{user: %User{} = user} = conversation) do
Expand Down
2 changes: 1 addition & 1 deletion lib/code_corps/messages/messages.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ defmodule CodeCorps.Messages do
@doc ~S"""
Gets a `CodeCorps.ConversationPart` record
"""
@spec get_part(integer) :: Conversation.t
@spec get_part(integer) :: ConversationPart.t
def get_part(id) do
ConversationPart |> Repo.get(id)
end
Expand Down
2 changes: 1 addition & 1 deletion lib/code_corps/policy/helpers.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ defmodule CodeCorps.Policy.Helpers do
@doc """
Retrieves conversation from associated record
"""
@spec get_conversation(Changeset.t() | ConversationPart.t() | map) :: Message.t()
@spec get_conversation(Changeset.t() | ConversationPart.t() | map) :: Conversation.t()
def get_conversation(%ConversationPart{conversation_id: conversation_id}), do: Repo.get(Conversation, conversation_id)
def get_conversation(%{"conversation_id" => conversation_id}), do: Repo.get(Conversation, conversation_id)
def get_conversation(%Changeset{changes: %{conversation_id: conversation_id}}), do: Repo.get(Conversation, conversation_id)
Expand Down