Conversation
begedin
reviewed
Dec 7, 2017
Contributor
begedin
left a comment
begedin
left a comment
There was a problem hiding this comment.
Other than a formatting issue, this is looking good. Fix that, and I can merge it tomorrow morning.
| user=user | ||
| action='hide' | ||
| }}`); | ||
| } |
Contributor
There was a problem hiding this comment.
You got some indentation crap here. You could probably fit it all onto a single line to.
begedin
approved these changes
Dec 8, 2017
begedin
force-pushed
the
rewrite-integration-tests-for-user-dropdown-component-to-use-page-objects
branch
from
c73ce73 to
a2c3d41
Compare
begedin
deleted the
rewrite-integration-tests-for-user-dropdown-component-to-use-page-objects
branch
joshsmith
reviewed
Dec 8, 2017
|
|
||
| renderPage(); | ||
| page.click(); | ||
|
|
Contributor
There was a problem hiding this comment.
The extra space here should be cleaned up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
References
Fixes # 772
Progress on: #