Update ember-stripe-elements to the latest version 🚀 #1629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@snewcomer would you mind seeing if we need to fix this in our code? I cannot remember if we yield the |
snewcomer
force-pushed
the
greenkeeper/ember-stripe-elements-0.3.0
branch
from
24bdc6c to
1eaeb7a
Compare
joshsmith
approved these changes
Dec 22, 2017
snewcomer
force-pushed
the
greenkeeper/ember-stripe-elements-0.3.0
branch
from
1eaeb7a to
086f8d9
Compare
joshsmith
approved these changes
Dec 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 0.3.0 of ember-stripe-elements was just published.
The version 0.3.0 is not covered by your current version range.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
It might be worth looking into these changes and trying to get this project onto the latest version of ember-stripe-elements.
If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.
Release Notes
Release 0.3.0Upgrade Instructions
This change fixes a conflict where we had both an
errorevent and anerroron the Stripe Element component.If you previously accessed the
error, e.g. by yielding to a block with your component, you should now prefer accessingstripeError.The
errorevent still fires as before.Changelog
Commits
The new version differs by 5 commits.
f6f231aRelease 0.3.05b674b2Merge pull request #23 from snewcomer/fix-error2543833rearrange error setter close #2277a2affMerge pull request #24 from snewcomer/upgrade-2.17cb06f25Upgrade to 2.17See the full diff
FAQ and help
There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper bot 🌴