Merged
Conversation
Override johnny-five's Piezo.prototype.note because it's playing the wrong frequencies.
Hamms
approved these changes
Apr 12, 2017
| /** | ||
| * We override johnny-five's note() function because there seems to be a bug | ||
| * where it computes the frequency incorrectly. | ||
| * If that bug gets fixed, we should be able to remove this patch. |
Contributor
There was a problem hiding this comment.
nit: might be nice to mention here that we'll also want to remove the tests for the patch
Contributor
Author
There was a problem hiding this comment.
I actually might leave the tests - I've been adding unit tests in our project covering behaviors we particularly care about from Johnny-Five.
|
Hi! Let's get things fixed! :D cc @lyzadanger |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Override johnny-five's
Piezo.prototype.notebecause it's playing the wrong frequencies, at least in Maker Toolkit. I think this is a bug in their component and I'm working on getting it fixed upstream. In the meantime it's fairly easy to patch in a fix in our wrapper.Bug easily repro'd in this app, in which all three buttons should play an A4 (440Hz) but calling
note('A4')obviously plays a different pitch.