Farsi site - Show Hour of Code hamburger link on small desktop#61246
Merged
Farsi site - Show Hour of Code hamburger link on small desktop#61246
Conversation
TurnerRiley
approved these changes
Sep 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue found here where the Hour of Code hamburger link was not showing in the hamburger for small desktop for the https://code.org/global/fa site.
The issue arose because the hamburger items are being hidden with CSS on code.org (not on the Ruby backend like studio.code.org) so I needed to add a class to select the Farsi-specific hamburger and could then hide the appropriate amount of links.
Links
Jira ticket: ACQ-2432
Testing story
Tested locally to make sure the right hamburger links are showing up on both the https://code.org/global/fa and https://code.org sites.
Untitled.mov