Remove Babel loose: true class except for JS Interpreter and Maker #65902
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to:
This PR removes
"loose": truefrom the@babel/plugin-transform-classesplugin only when transpiling Blockly.In our environment,
"loose": truecauses Babel to transpilesuper.prop = valueasthis.prop = value. When Blockly introduced thesize_accessor inFieldInput, our transpilation led to infinite recursion:super.size_ = valwas rewritten asthis.size_ = val.This override impacts everywhere except two specific folders, hopefully avoiding the regressions introduced by #65894
This change avoids the recursion bug introduced by Babel rewriting
super.size_ = valasthis.size_ = val, which broke Blockly’s new accessor-based Field implementation.PR Checklist: