Fixes issue with concatenated nrps url param by nicklathe · Pull Request #69918 · code-dot-org/code-dot-org

nicklathe · 2025-12-05T00:04:13Z

De-duplicates possible dupplicated params as part of the NRPS response from certain LMS platforms

Warning!!

We have entered Pixel Lock for Hour of AI! All merges to the staging branch from Dec 2 through Dec 12 must go through live change review and be deemed critical for supporting the Hour of AI. External contributions will not be accepted at this time.

For non-critical changes, please change your base to staging-next and delete this warning. We will merge staging-next into staging on Dec 15, 2025.

Links

Jira:

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Creation Checklist:

Tests provide adequate coverage
Privacy impacts have been documented
Security impacts have been documented
Code is well-commented
New features are translatable or updates will not break translations
Relevant documentation has been added or updated
User impact is well-understood and desirable
Follow-up work items (including potential tech debt) are tracked and linked

'

This reverts commit 67c2443.

Staging into staging-next

…o 6000ms

[AITT-1297] Ensure personalization intersticials and final gif auto progress uses

* renaming and update accept-reject schema to include folderId and id for each file * ask for id and folderId of updated file and validate name * move updating openFiles to helper function, add numeric suffix for file name if duplicate * add unit tests for getMergedAiTutorCodeWithSource helper function

…ed above chat events in dom to fix tab order (#69883)

…ages (#69892) * reset load error correctly * Update apps/src/lab2/views/components/Instructions/ResourcePanel/VersionHistory/VersionHistoryPanel.tsx Co-authored-by: Kelby Hawn <9256643+kelbyhawn@users.noreply.github.com> --------- Co-authored-by: Kelby Hawn <9256643+kelbyhawn@users.noreply.github.com>

* experimentally set sc tunnel idle timeout to 1s in ci * explicitly pass http-idle-conn-timeout flag to sc run * debug SAUCE_HTTP_IDLE_CONN_TIMEOUT * increase sauce log levels * also try warn log level * fix sc log syntax * verbosely log proxy header output * dump sauce connect log * limit http logs to proxy errors * reduce log level to INFO * set up bash trap to dump sc log * introduce an error in angle_helper.feature to make the build fail * Tail the Sauce Connect log for real-time visibility in CI * Revert "introduce an error in angle_helper.feature to make the build fail" This reverts commit f6fff21. * remove proxy error logging * Revert "Tail the Sauce Connect log" and go back to trap This reverts commit 45b94eb. * remove ineffective idle timeout setting * Reapply "Tail the Sauce Connect log" This reverts commit 5ad1c8f. * use system to invoke tail * Revert "use system to invoke tail" This reverts commit 856f25d. * Revert "Reapply "Tail the Sauce Connect log"" This reverts commit e7d6340. * rerun * introduce artificial 5xx error into ui tests * -m [skip local webdriver] * Revert "introduce artificial 5xx error into ui tests" This reverts commit 893deaf. * increase ulimit per saucelabs warning * Update schema cache dump after schema changes. * extract LOG_FILE_PATH * dump log file using ruby instead * remove unused daemonize param * remove one more mention of daemonize * add dump_logs option * revert schema cache * add verbose flag * rerun drone --------- Co-authored-by: Continuous Integration <dev@code.org>

…-components tidy 🧹: Remove radium from applab components

* Update aidiff message model with potential artifact * Update version * Update the version number for message migration

Save podcast script to AiLessonSummary table

* Move unit selector to shared folder * Fix * Move the lesson sel and add unit sel * Add lesson selector * Fix test * Add auth * Fix test * Add labels

…9893) * Replace CanEnableAITutor with an experiment and add the AI Settings tab behind the experiment. * remove unnecessary spread * Fix teacher nav bar tests

* Fix "with exception" calls to Honeybadger.notify_cronjob_error * Also update daily_weather to use this call

…ts + stories (#69801) * feat(component-library): checkbox styles parity with radio (gaps, order, transitions) * feat(component-library): checkbox add textThickness, ariaLabel, aria-checked mixed, className/children, memo * feat(component-library): checkbox stories add label weights, multiline, custom content; remove legacy Supernova stories * chore(prettier): format checkbox.module.scss * chore(prettier): format Checkbox.tsx * chore(prettier): format Checkbox.story.tsx * chore(typecheck): add required checked/onChange to CheckboxesWithCustomContent story * chore(lint): remove any casts in Checkbox; use typed HTML attributes * chore(typecheck): avoid reading className from spread HTML attributes in Checkbox * chore(a11y): align Checkbox aria-label fallback with RadioButton (use ||) * chore(stories): remove redundant comment from Checkbox stories * chore(Checkbox): remove memoization from Checkbox component --------- Co-authored-by: denyslevada <levada.denys@gmail.com>

* fix dropdown persistence issue * fix comment typos * clean up * blur the button focus style * more clean up * update comments * update comments again * update solution to use custom event * handle memory leaks

…p UI (#69902) * add AiTutorVersionFileChip - wip * more style updates * use senary for dark mode improvement * add file chips to action notification * add accepted/rejected icon * add functionality to handlePreviewClick * update description with example of what should be returned for a modified file * add time stamp to aiFilePathToPreview so that effect is triggered even after user enters url manually * add JS * update comment, remove logs * styling updates

- De-duplicates possible dupplicated params as part of the NRPS response from certain LMS platforms Signed-off-by: Nick Lathe <nick.lathe@code.org>

nicklathe · 2025-12-05T00:04:35Z

dashboard/test/lib/clients/lti_advantage_client_test.rb

    assert_equal 150, res[:members].length
  end
+
+  test 'handles duplicate query parameters correctly' do


This test is failing, still poking at it.

nicklathe · 2025-12-05T00:06:11Z

dashboard/lib/clients/lti_advantage_client.rb

    raise ArgumentError unless client_id && issuer
    @client_id = client_id
    @issuer = issuer
+    @page_limit = PAGE_LIMIT


Since we weren't overriding this via the method parameter, I thought it might be safer to declare it as a const here. It's also cleaner than passing it down to the build_uri method

nicklathe · 2025-12-05T00:14:13Z

dashboard/test/lib/clients/lti_advantage_client_test.rb

-    @page_2_url = 'https://example.com/api/lti/courses/1234/memberships?rlid=1234&page=2'
-    @page_3_url = 'https://example.com/api/lti/courses/1234/memberships?rlid=1234&page=3'
+    @page_2_url = 'https://example.com/api/lti/courses/1234/memberships?limit=100&page=2&rlid=1234'
+    @page_3_url = 'https://example.com/api/lti/courses/1234/memberships?limit=100&page=3&rlid=1234'


The order of these query params changed now that we're calling .merge. My guess is that method orders the keys alphabetically, but I haven't looked into that yet.

Erin007 and others added 30 commits October 28, 2025 11:24

WIP Langfuse POC

6133d7c

use codex to remove Radium from 2 project components

496ecae

move relevant variables and setters to redux

e959082

Merge branch 'staging' into lesson-prompt-open-aita-thread

4266df6

add analytics logging for copy button

2beeed4

formatting fix

ff6cb10

remove changes to string constants file

9111fd8

only show initial suggested prompts for default threads

fd3463c

restructure order of dispatch and selector

cb19c2a

track thread and prompt in redux

305e397

add unit tests

ab482f0

merge in staging

8f8a4d2

add personalization strings and unit tests

1bd40b0

Merge branch 'staging' into lesson-prompt-open-aita-thread

a26ce79

log copy events

49427ca

'

update rehype comment

6c3a05c

merge in staging and fix IsAiDiffContainerOpen conflict

edb1088

unify redux variable that tracks if the chat is open or not

6431908

split up response format based on request type

8c308f7

merge in staging

4bcc794

merge staging, accept both changes in package.json

0cbff7b

remove job request call since we arent saving them yet

e6b997e

allow transcript to be retrieved through fetch call instead of saving:

0255ee3

add route

bc68bfe

ensure prompt is in second person directed at the listener

3a062ea

add unit tests

e7bbd7d

Merge branch 'staging' into lesson-prompt-open-aita-thread

0883eba

Merge branch 'staging' into lesson-prompt-open-aita-thread

e6b499a

put langfuse api keys in secrets

47ef4dc

merge in staging

c5f624e

sureshc and others added 25 commits December 3, 2025 09:20

Disable HTTP connection pooling to WebPurify. (#69846)

67c2443

Revert "Disable HTTP connection pooling to WebPurify. (#69846)" (#69877)

820adb7

This reverts commit 67c2443.

Merge pull request #69881 from code-dot-org/staging

c19879a

Staging into staging-next

fix: increase delay for non-final personalization steps from 5000ms t…

b2b1369

…o 6000ms

Merge pull request #69821 from code-dot-org/denys/aitt/aitt-1297

928bdd8

[AITT-1297] Ensure personalization intersticials and final gif auto progress uses

save podcast script to database

7b5a89b

updating dropdown to be a button with tooltip (#69867)

3e353b7

fix: add aria-label and aria-controls to scroll to bottom button. mov…

5c8578e

…ed above chat events in dom to fix tab order (#69883)

bug fix (#69895)

c189338

Merge pull request #69876 from code-dot-org/remove-radium-from-applab…

295610d

…-components tidy 🧹: Remove radium from applab components

remove unnecessary fetch param

31f8852

smarter sending of debounced source (#69899)

927c1d2

Ceara/aitt 1184 migration potential artifact (#69891)

b3de19d

* Update aidiff message model with potential artifact * Update version * Update the version number for message migration

Merge pull request #69890 from code-dot-org/save-podcast-script-to-db

27ad8d8

Save podcast script to AiLessonSummary table

[Snapshot] Wire up lesson and unit selectors in header (#69871)

f85bd9f

* Move unit selector to shared folder * Fix * Move the lesson sel and add unit sel * Add lesson selector * Fix test * Add auth * Fix test * Add labels

Tutor Permissions: Display AI Settings tab behind experiment flag (#6…

878b46a

…9893) * Replace CanEnableAITutor with an experiment and add the AI Settings tab behind the experiment. * remove unnecessary spread * Fix teacher nav bar tests

Fix "with exception" calls to Honeybadger.notify_cronjob_error (#69905)

887ee3c

* Fix "with exception" calls to Honeybadger.notify_cronjob_error * Also update daily_weather to use this call

add documentation to NPS survey admin page(#69903)

adbad59

Codebridge: fix dropdown persistence issue in the File Manager (#69885)

a3e9fe2

* fix dropdown persistence issue * fix comment typos * clean up * blur the button focus style * more clean up * update comments * update comments again * update solution to use custom event * handle memory leaks

Fixes issue with concatenated nrps url param

18a2c03

- De-duplicates possible dupplicated params as part of the NRPS response from certain LMS platforms Signed-off-by: Nick Lathe <nick.lathe@code.org>

nicklathe commented Dec 5, 2025

View reviewed changes

Manually increment page for schoology only

e98e35f

nicklathe changed the base branch from staging-next to staging December 5, 2025 20:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes issue with concatenated nrps url param#69918

Fixes issue with concatenated nrps url param#69918
nicklathe wants to merge 135 commits intostagingfrom
nlathe/nrps-query-fix

nicklathe commented Dec 5, 2025

Uh oh!

nicklathe Dec 5, 2025

Uh oh!

nicklathe Dec 5, 2025

Uh oh!

nicklathe Dec 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

nicklathe commented Dec 5, 2025

Warning!!

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Creation Checklist:

Uh oh!

nicklathe Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

nicklathe Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

nicklathe Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants