Merged
Conversation
Contributor
Author
|
"DatePicker" sounds like a less exciting but more descriptive name for "Tinder". In this case, it's this little calendar component: |
Erin007
requested review from
a team and
lfryemason
and removed request for
a team
lfryemason
approved these changes
Feb 19, 2026
Contributor
lfryemason
left a comment
lfryemason
left a comment
There was a problem hiding this comment.
Amazing! Thanks for doing this cleanup!
| States, | ||
| } from '@cdo/apps/generated/pd/sharedWorkshopConstants'; | ||
|
|
||
| import DatePicker from '../../../sharedComponents/DatePicker'; |
Contributor
There was a problem hiding this comment.
Optional nit: you could change these imports with lots of ../../ to @cdo/apps/sharedComponents/DatePicker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few little updates:
date_pickertoDatePickerto align with conventionDatePickerinto sharedComponents since it's used in both levelbuilder and pd workshopsDatePickerinto scss moduleDatePicker