AI Tutor: add warning dialog when mid-accept/reject and trying to navigate between lab2 levels#72140
Merged
Merged
Conversation
bencodeorg
commented
Apr 14, 2026
| return; | ||
| } | ||
| // Notify the Lab2 system (that handles changing levels without reload) about the level change. | ||
| // The browser history API does not provide access to the state of the page we just came from, |
Contributor
Author
There was a problem hiding this comment.
This is true, but we're able to reconstruct the "from" page from Redux (see new logic), so I removed this comment.
fisher-alice
approved these changes
Apr 20, 2026
Contributor
fisher-alice
left a comment
fisher-alice
left a comment
There was a problem hiding this comment.
Cool updates! And nice work on #72063 as well. Just left a small comments.
| ); | ||
|
|
||
| const dispatch = useAppDispatch(); | ||
| const dialogControl = useDialogControl(); |
Contributor
There was a problem hiding this comment.
Nit: maybe as a follow-up down the line, we could extract the navigation guard effects in a hook.
Contributor
Author
There was a problem hiding this comment.
Good thought, I like it!
| await dispatch(rejectAiTutorVersion(files)); | ||
| }, [dispatch, files]); | ||
|
|
||
| useEffect(() => { |
Contributor
There was a problem hiding this comment.
Maybe add a comment here and the 'Block in-app level navigation...'
Contributor
Author
There was a problem hiding this comment.
Done, thanks! Added one to the useEffect below as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a warning dialog if you try to navigate to another lab2 level when in the middle of accepting/rejecting AI Tutor changes. It offers the same behavior if you are using the forward/back browser history to navigate between levels. Finally, it also adds a "reject" event to your chat history if you do navigate to another lab2 level.
block.nav.mid.accept.reject.mov
Links
Testing story
Tested manually (see video above).