fix: stop reporting expected swap and on-ramp outcomes as notifiable Bugsnag warnings#1055
Merged
bmc08gt merged 1 commit intoJul 10, 2026
Merged
Conversation
…Bugsnag warnings Two production Bugsnag "warning" issues were expected outcomes, not app defects: - Swap poll timeouts and backend-driven terminal states (FAILED/CANCELLED) threw a bare SwapError.Other() (a NotifiableError). Add dedicated SwapError.Timeout and SwapError.Terminal(state) subtypes that are not NotifiableError, and throw them from SwapPoller. Genuinely unexpected cases (UNKNOWN state, getSwap failures) still throw SwapError.Other. - Solana transaction simulation / on-chain program rejections (e.g. "custom program error: 0x1") were reported via ErrorUtils.handleError. Add RpcException.isSimulationError and skip the Bugsnag report for those in PhantomWalletController, while still surfacing the typed failure to the user.
github-actions
Bot
added
area: crypto
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two production Bugsnag "warning" issues were expected outcomes, not app defects:
Swap poll timeouts and backend-driven terminal states (FAILED/CANCELLED) threw a bare SwapError.Other() (a NotifiableError). Add dedicated SwapError.Timeout and SwapError.Terminal(state) subtypes that are not NotifiableError, and throw them from SwapPoller. Genuinely unexpected cases (UNKNOWN state, getSwap failures) still throw SwapError.Other.
Solana transaction simulation / on-chain program rejections (e.g. "custom program error: 0x1") were reported via ErrorUtils.handleError. Add RpcException.isSimulationError and skip the Bugsnag report for those in PhantomWalletController, while still surfacing the typed failure to the user.