refactor(core-ui): extract shared UI into :apps:flipcash:core-ui - #1243
Merged
Conversation
Move the shared Compose UI out of :apps:flipcash:core into a new :apps:flipcash:core-ui module so it can depend on :shared:featureflags (core cannot without a dependency cycle). - Move all composables under core/ui (+ internal/ui/previews) to core-ui, keeping the com.flipcash.app.core.ui package so call-site imports are unchanged. - Keep SteppedFlowRoute (a route type, not UI) in core, relocated to the core.navigation package. - Wire core-ui into feature modules via the feature convention plugin, excluding core, core-ui and featureflags to avoid a cycle; add explicit deps for the two non-feature-plugin consumers (app, chat-ui).
bmc08gt
force-pushed
the
refactor/extract-core-ui
branch
from
August 14, 2026 23:55
a611c6a to
cb05653
Compare
github-actions
Bot
added
type: feature
bmc08gt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract shared Flipcash Compose UI into a dedicated
:apps:flipcash:core-uimodule.com.flipcash.app.core.ui.*composables (TileButton, TokenCard, TokenCardStack, NavigationBar, Callout, flow/processing/transition helpers, etc.) out of:apps:flipcash:coreinto a new:apps:flipcash:core-uilibrary module.core-ui/build.gradle.ktsand wires the module into consumers.SteppedFlowRoutefromui/flowintonavigationand updatesAppRouteaccordingly.Mostly pure file moves (no behavioral change) so the shared UI can be depended on without pulling in the rest of
:core.Test plan
./gradlew :apps:flipcash:app:compileDebugKotlinpasses.