feat(myaccount): add a Change Display Name row - #1299
Merged
Conversation
Node 9277:121893 puts Change Display Name at the top of My Account, above Require Biometrics. It was left out of the You-tab rebuild so it could land on its own, with the display name reachable only through the staff-gated User Profile screen in the meantime. The row opens AppRoute.UpdateUserProfile with includePhoto = false, so the flow shows the name step alone and returns to My Account on save or back rather than walking on to photo selection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node
9277:121893puts Change Display Name at the top of My Account, above Require Biometrics. It was left out of the You-tab rebuild (#1291) so it could land on its own — until now the display name was only editable through the staff-gated User Profile screen.The row opens
AppRoute.UpdateUserProfile(origin = Menu.MyAccount, includeName = true, includePhoto = false), so the flow shows the name step alone and returns to My Account on save or on back, rather than walking on to photo selection. That's the same routeUserProfileScreenalready uses for its Edit Name affordance.UserProfilestays where it is, staff-gated — it's the whole profile editor (contact methods, photo, name); this row is just the name.The icon is
Icons.Outlined.Badgeas a stand-in: the design draws a grey placeholder box for it, same as the other rows on this screen.