fix(profile): confirm the reversible profile changes in the grey banner - #1380
Merged
Conversation
All four profile-change confirmations used showAlert, so a display name, profile picture, or minimum tip edit got the red destructive banner and "Are you sure you want to permanently change ...?" — the same treatment as releasing a username, which is the only one of the four the user may not be able to undo. Those three move to showMessage (DEFAULT, bannerThemed grey) and state what the change does instead of asking the user to be sure. Username keeps the red banner and its extra sentence about losing the old handle. Matches iOS, where DialogItem.confirmProfileChange already routes username to .alert and the rest to .info on the same copy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All four profile-change confirmations went through
BottomBarManager.showAlert, so changing a display name, profile picture, or minimum tip raised the red destructive banner and asked "Are you sure you want to permanently change ...?" — the same treatment as changing a username, which releases the old handle for anyone to claim and is the only one of the four the user may not be able to undo.The three reversible edits now use
showMessage(DEFAULT→bannerThemed,#252526) and state what the change does:Titles and confirm buttons are unchanged, and username keeps the red banner along with its sentence about losing the old handle.
This is the shape iOS already ships:
DialogItem.confirmProfileChangeroutes username to.alertand the other three to.infoon the same wording. iOS says "profile photo" in its subtitle while its title and button say "Profile Picture"; this keeps "picture" throughout, so the Android modal is internally consistent and the two platforms differ by that one noun.