fix(shared-core): restore the KikCode figure API to the SPM sources - #1401
Merged
Conversation
The CGPath figure wrappers — `KikCode.figure`, the badge, and the SVG path parser they read artwork through — only ever existed on `feat/shared-badge-cgpath`, which 0.3.1 was published from. 0.4.0 was published from `code/cash`, and the publish workflow stages the package by `rm -rf spm-repo/Sources spm-repo/Tests` and re-copying from the checkout, so cutting it deleted all three files. iOS has not built since: `type 'KikCode' has no member 'figure'`. Cherry-picked from 22bcafb unchanged. Kotlin needs nothing — the 0.4.0 framework header still exports `KikCodeGeometry`, `KikCodeBadge`, `KikCodeSpec` and the mark types the wrappers read, so only the Swift side was lost. `KikCodeFigureTests` comes back with them, which is also why the loss went unnoticed: `shared-core-tests.yml` runs the package's own suite, and the suite was deleted along with the sources it covers.
bmc08gt
added a commit
that referenced
this pull request
Sep 3, 2026
Picks up #1397 (UserFlags), #1401 (restores KikCode+Badge/KikCode+Figure/ SVGPath/KikCodeFigureTests), and #1400 (FocusPin/MessageRow/ MessageReadReporter/ReceiptRules) via the true fork point as the merge base, correcting an earlier rewrite that had reparented this branch onto code/cash's graph without actually merging its content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CGPath figure wrappers —
KikCode.figure, the badge, and the SVG path parser they readartwork through — only ever existed on
feat/shared-badge-cgpath, which 0.3.1 was publishedfrom. That branch never merged. 0.4.0 was published from
code/cash, and the publish workflowstages the Swift package by
so cutting 0.4.0 deleted all three files from the published package. iOS has not built since:
type 'KikCode' has no member 'figure'.Pinning back to 0.3.1 is not an option —
FlipcashCorenow usesSharedCoreKit.Base58,SharedEd25519and the Hashes wrappers, none of which exist in 0.3.1.This cherry-picks 22bcafb unchanged. Kotlin needs no change: the 0.4.0 framework header
still exports
KikCodeGeometry,KikCodeBadge,KikCodeSpecand the mark types the wrappersread, so only the Swift side was ever lost.
KikCodeFigureTestscomes back with the sources, which is also why the loss went unnoticed —shared-core-tests.ymlruns the package's own suite, and the suite was deleted along with thecode it covers.
0.4.1 goes out from
code/cashonce this merges, and iOS bumps to it. Publishing from a branchis what produced this in the first place, so it waits for the merge.