chore(direct-send): delete the module left behind by the send-tab removal - #1419
Merged
Conversation
…oval #1182 removed the send tab and the `AppRoute.Sheets.Send` route it opened, dropped `:apps:flipcash:features:direct-send` from `settings.gradle.kts` and the app's dependencies, and deleted the two maestro flows that drove it — but left the module's sources in the tree. They have sat there uncompiled for 240 commits, and `PhoneGateLandingScreen` still navigates to the deleted route, so re-including the module would not configure. Nothing outside the module referenced `com.flipcash.app.directsend`, and the `SendStep`/`SendResult` flow contract in `:apps:flipcash:core` had no other consumer, so both go with it. AndroidManifest, AppRouter and NotificationService keep their comments explaining why chat deeplinks are deliberately unrouted — that reasoning outlives the module. The baseline profile still carried 315 rules for `com/flipcash/app/directsend` classes that no longer ship; it has not been regenerated since #1029.
The catalog had drifted from the modules that actually exist. #1291 deleted the standalone App Settings screen and its module — its one surviving toggle moved into My Account — but the catalog still carried an `appsettings` row pointing at a directory that is gone, and `AppSettingsCoordinator` now lives in `:apps:flipcash:shared:appsettings`, not a feature. `tipping` and `user-profile` were missing from the full module list entirely, and neither had a row despite being user-facing flows. Both get one, replacing `appsettings` with `menu` — the "You" tab where those settings rows ended up. The list now matches `settings.gradle.kts` exactly: 26 modules, the same 26 the header claims. (`features/home/` still exists on disk as stale build output; it has no tracked files and left `settings.gradle.kts` with the module it held.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apps/flipcash/features/direct-sendis dead code. #1182 removed the send tab, deleted theAppRoute.Sheets.Sendroute the flow opened, dropped:apps:flipcash:features:direct-sendfromsettings.gradle.ktsand from the app's dependencies, and deletedmaestro/direct_send.yamlandmaestro/send_to_contact.yaml— but left the module's sources behind. Nothing has configured or compiled them in the 240 commits since.The module also could not come back as-is:
PhoneGateLandingScreenstill navigates toAppRoute.Sheets.Send, which #1182 deleted fromAppRoute.kt.Removal, rather than repair, is what the history supports. The same commit took out every entry point and the route itself, and three call sites now carry comments explaining the absence as intentional —
AndroidManifest.xmldeclines the/chat/.*App Link, andAppRouterandNotificationServiceboth fall back to a plain launch because the flow the link opened is gone. Those comments stay; the reasoning outlives the module.What goes with it:
apps/flipcash/core/.../core/send/SendStep.kt— theSendStep/SendResultflow contract had no consumer outsidedirect-send.ChatStep's separateChatSendResult, used bymessenger, is untouched.com/flipcash/app/directsendclasses that no longer ship. The profile has not been regenerated since perf(benchmark): extend baseline profile to send/chat, search, and cash bill #1029, so they were still listed.No source outside the module referenced
com.flipcash.app.directsend.Feature catalog
Second commit, separable from the first.
docs/architecture/features/README.mdhad drifted from the modules that exist, in three ways beyond thedirect-sendentry:appsettingsrow pointing at a directory feat(you): rebuild the You tab around the tip card #1291 deleted along with the standalone App Settings screen.AppSettingsCoordinatornow lives in:apps:flipcash:shared:appsettings, not a feature module. Replaced by amenurow — the "You" tab those settings rows moved into.tippinganduser-profilewere absent from the full module list and had no row, despite both being user-facing flows. Both get one.settings.gradle.kts.The list now matches
settings.gradle.ktsexactly, at the 26 modules the header claims.One thing left alone:
apps/flipcash/features/home/still exists on disk, but only as stalebuild/output — it has no tracked files and leftsettings.gradle.ktswith the module it used to hold.