fix(buy): lead the Get receipt with what you pay - #631
Merged
Conversation
The Get receipt anchored on "You Get" and closed with "You Pay", so the figure that leaves your balance was the last thing read — and the fee breakdown sat above the total it decomposes rather than below it. Swap the two anchors. Get now reads the same way as Convert: the outgoing side on top, its breakdown underneath, the incoming side last. The padding stays with the positions, not the content, so the card's spacing is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Get receipt anchored on "You Get" and closed with "You Pay", so the figure that actually leaves your balance was the last thing read — and when a conversion fee applies, the breakdown sat above the total it decomposes rather than below it.
Swap the two anchors. Get now reads the same way as the Convert receipt: the outgoing side on top, its breakdown underneath, the incoming side last.
The padding modifiers stay with the positions rather than the content, so the card's spacing is unchanged — the top anchor keeps its 24pt top pad, and the bottom anchor keeps the
chargesFee ? 0 : 24top pad that closes the gap when no breakdown is present.No test changes needed:
BuyConfirmationUIScreenmatches "You Pay" by label prefix, not by position.Android half: code-payments/code-android-app#1312. Both platforms swap the same two anchors; land them together so the Get receipt doesn't read differently on each.