fix(coding-agent): expose failed compaction attempts#326
Draft
minpeter wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compaction_startonce an automatic compaction owns its model/controllerThis is a one-commit follow-up to merged PR #310, based directly on its merge result.
Root cause
The final #310 controller-supersession fix moved
compaction_startafter authentication and request preparation. Anoverflow compaction that failed during those early preparation steps therefore consumed/released internal attempt
state without publishing the attempt. The next prompt could not prove that the overflow recovery had been retried,
and the established no-auth regression observed zero starts instead of two independent attempts.
The event now emits after model/controller ownership is proven but before fallible authentication/preparation. A
superseded controller still cannot emit; a valid owned attempt remains observable even when preparation returns early.
RED -> GREEN
main:does not consume the overflow compact-and-retry attempt when compaction fails before retryingcompaction_startevents, received zeroVerification
npm run check: passed--help: exit 0installinput: exit 1 with usageThe broader coding-agent full suite has unrelated load-sensitive MCP/app-server/temporary-filesystem failures which
pass directly; no compaction test remains failing.
Summary by cubic
Emit
compaction_startas soon as an automatic compaction owns its model/controller, before auth and preparation. This makes early preparation failures visible and preserves the single overflow retry attempt.Written for commit 62354c2. Summary will update on new commits.