fix(coding-agent): restore compaction preflight events#340
Closed
minpeter wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Superseded by the current-main ownership fix at minpeter@e1d0c4d on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compaction_startlistener supersessionRoot cause and attribution
Current main inherited the regression from PR #310 commit
b3f643e915:_runAutoCompaction()movedcompaction_startbelow auth/preparation validation and removed early terminal events. The existing no-auth characterization consequently observed zero starts instead of two.The exact owner boundary was reproduced before this change:
10a82f30d(parent of owner commit): PASSb3f643e915(PR fix(coding-agent): stabilize compaction lifecycle #310 head): FAIL, expected 2 / received 038bd3a3cf(merged main baseline): identical FAILThis repair is isolated from PR #328 and contains only the three compaction lifecycle files shown in the diff.
Verification
expected [] to have a length of 2 but got +0npm run build: passednpm run check: passed, including Biome, dependency/import/lock checks,tsgo, browser smoke, web UI, and Neo build/vet/testsPASS - no actionable findingsEvidence
Local evidence index:
local-ignore/qa-evidence/20260724-compaction-preflight-lifecycle/EVIDENCE.mdSupporting source-CLI artifacts:
local-ignore/qa-evidence/20260725-compaction-preflight-rpc/local-ignore/qa-evidence/20260725-compaction-preflight-mock/Original CI attribution:
local-ignore/qa-evidence/20260724-compaction-progress-live-cdp-final/ci-current-main-attribution/attribution.mdSummary by cubic
Restores auto-compaction preflight lifecycle events and balances start/end signals around auth/preparation checks. Prevents stale terminal events when a start listener supersedes controller ownership.
compaction_startbefore auth/prep; on preflight reject, emit a matching non-errorcompaction_end; recheck ownership after start to avoid stale ends.changes.md.Written for commit d027216. Summary will update on new commits.