[pull] main from TryGhost:main#1064
Merged
Merged
Conversation
no issue Added `apps/posts` and `apps/shade` to scoped workspaces in `.lintstagedrc.cjs` so eslint runs from within each package directory. This fixes the pre-commit hook failing because `eslint-plugin-tailwindcss` (via `tailwind-api-utils`) tries to require `tailwindcss/dist/lib/setupContextUtils.js` which only exists in Tailwind v3. Renamed the constant from `FLAT_CONFIG_WORKSPACES` to `SCOPED_WORKSPACES` since it now includes non-flat-config packages too.
no ref Replaced the old `node_modules` caching strategy with pnpm's built-in content-addressable store caching via `actions/setup-node`'s `cache: pnpm`. Every CI job now runs a clean `pnpm install --frozen-lockfile` against the cached store, producing a deterministic symlink tree from scratch. ### Why sqlite3 needs `--force` sqlite3 is an `optionalDependency` in `ghost/core/package.json`. Without `--force`, pnpm may skip installing/linking it when restoring from a cached store. `--force` ensures all optional dependencies are installed regardless. This only applies to the 2 sqlite3 matrix jobs. ### Benefits - **Deterministic installs** — every job gets a clean `node_modules` from `pnpm install`, no symlink ambiguity - **Better cache hit rate** — cache key is based on lockfile hash (not lockfile + commit SHA), so cache hits across commits that don't change dependencies - **Simpler CI config** — removed custom restore-cache action, install-deps.sh retry wrapper, cross-job dependency cache key passing, and the "sleep 10 and retry" cache restore hack - **Independent jobs** — jobs no longer depend on `job_setup` for a shared cache key; each caches independently
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )