[pull] main from TryGhost:main#1070
Merged
Merged
Conversation
no ref This is a test-only change. I think Claude Opus 4.7's explanation is reasonably good: > The test at `comments.test.js:1362` uses `dbFns.addCommentWithReplies` to create a parent comment and a reply back-to-back without explicit `created_at` values. Both rows rely on the model's default timestamp (`new Date()` at save time). > > The admin browseAll controller at `comments-controller.js:166` sorts by `created_at desc` and the SQL has no secondary tiebreak. When the two inserts land in the same millisecond, MySQL happens to return rows in insertion order (parent first, reply second), which matches the stored snapshot `[commentMatcher, commentMatcherWithParent]`. When the reply spills into a newer millisecond, `desc` puts the reply first — the snapshot then sees `parent` (reply's parent object) missing from index 1 and the assertion fails exactly as in the CI log.
no issue - Merged gift subscription tests from three scattered files into `ghost/core/test/e2e-api/members/gift-subscriptions.test.js` - Deleted `ghost/core/test/e2e-api/members/gifts.test.js` (all tests moved) - Removed 2 gift-related tests from `ghost/core/test/e2e-api/members/signin.test.js` - Organized tests into clear describe blocks: Purchase, Refund, Check redeemability, and Redeem (logged-in + magic link flows) - Added new tests for redeemability checks (already redeemed, expired, refunded) and magic link edge cases (existing member redemption, second-attempt failure)
no ref - Persists the scheduled/backfill email analytics fetch to the database so it survives Ghost restarts. Uses the existing `metadata` column on the `jobs` table to store the begin/end time window as JSON; `finished_at` continues to track progress within that window (same as other fetch types), but since the scheduled job has a fixed time window — not computed relative to now — both the start and end times need explicit persistence. - On startup, `restoreScheduled()` is called once (on the first `startFetch()` cycle) to restore any in-progress schedule from the database. - Adds custom date range support to the debug UI (`/posts/analytics/:id/debug`). A "Custom Date Range" option now appears alongside the existing "Refetch Analytics" button, with datetime inputs for arbitrary begin/end dates. The API endpoint accepts optional `begin`/`end` parameters, falling back to the existing computed defaults. The scheduled/backfill job in Ghost was previously held only in memory. For very large data sets, it was often the case that Ghost would get restarted before the backfill job ever finished, making it of limited value. This adds persistence to that job, just like our other email analytics jobs/tasks, and expands the `/debug` route to allow us to set a custom datetime from the frontend so we're not stuck with the defaults (post publish + 7d).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )