[pull] main from TryGhost:main#1151
Merged
Merged
Conversation
no ref - **`i18n.js`**: dropped the `/** @type {import('i18next').i18n} */` annotation. `i18next` isn't a declared dep of `ghost/core` and adding it just for a type ref isn't warranted — the variable holds `require('@tryghost/i18n')`, Ghost's own wrapper. - **`sentry-knex-tracing-integration.js`**: removed the `@typedef SentryIntegration` and `@implements` annotations. The `Integration` type is only exported from `@sentry/types`, which isn't a direct dep of `ghost/core` (only `@sentry/node` is). Replaced with a prose comment. - **`knip.json`**: added an ignore glob for `ghost/core/test/utils/fixtures/themes/**/assets/built/**`. Knip was scanning the minified theme fixture bundles and treating their internal `ev-emitter` references as unresolved imports — false positives.
no ref
`apps/comments-ui/postcss.config.cjs` lists `'postcss-import': {}` as a plugin, but the package is not declared in `apps/comments-ui/package.json`.
no ref `apps/signup-form/vite.config.mts` referenced a `setupFiles: './test/test-setup.js'` that has never existed in the repository, surfacing as an unresolved entry in `pnpm knip`.
no ref - Added optional `pnpm dev:supervisor` wrapper for testing supervised PNPM/Nx dev shutdown. - Added `pnpm dev:status` diagnostics for repo-local dev processes. - Hardened public app `concurrently` dev scripts to stop sibling processes together.
…esh declarations (#27756) no ref Two of the eslint plugins in `apps/comments-ui` and `apps/signup-form` are vestigial — declared in `package.json` but not referenced in either workspace's `.eslintrc` config or anywhere else. Removing them clears 4 entries from the knip baseline.
no ref `pnpm-workspace.yaml` pinned `vitest: 4.1.2` in the top-level catalog while `@vitest/coverage-v8: 4.1.5` in the same catalog declares an exact peer on `vitest@4.1.5`.
closes https://linear.app/ghost/issue/NY-1282 This change should have no user impact. This renames "welcome email automation" to "automation" across the codebase. It does *not* rename any other models, so `WelcomeEmailAutomatedEmail` and `WelcomeEmailAutomationRun` still exist. This should be safe because we take sites offline for migrations.
…27568) no ref Two changes to `.github/workflows/devcontainer-build.yml`: 1. **Restores push-to-main auto-trigger** that #27553 stripped. The TryGhost org bootstrap is done — the manual dispatch from #27553 successfully published `ghcr.io/tryghost/ghost-devcontainer:latest`, confirming `GITHUB_TOKEN` can push from this repo. 2. **Adds `linux/arm64` alongside `linux/amd64`** via `docker/setup-qemu-action` so M-series Mac developers pull a native arm64 layer from the manifest list instead of needing `--platform linux/amd64` every time.
towards https://linear.app/ghost/issue/NY-1255 ref #27904 ref 9afbdc2 We should use the same version of `bson-objectid` everywhere. I think this is a useful change on its own, but also makes [an upcoming change][0] easier. [0]: #27904
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )