Conversation
Absolutely did not notice but… we're missing a README for the mermaid package, which is OK, is new, but come on! README Time! ### Change type - [ ] `bugfix` - [ ] `improvement` - [ ] `feature` - [ ] `api` - [x] `other` ### Release notes - Added a README to our mermaid package! --------- Co-authored-by: Guillaume <guillaume@tldraw.com>
…8287) In order to prevent token leaks in Discord error notifications, this PR adds sanitization of `--token VALUE` patterns (e.g. `vercel --token xxx`) in the Discord message helper. ### Change type - [x] `bugfix` ### Test plan - Grep for `--token` usage in CI scripts to verify the pattern matches real usage ### Code changes | Section | LOC change | | -------------- | ---------- | | Config/tooling | +3 / -0 |
Improves the `sanitizeVariables` function in the Discord notification helper so that redacted values render as inline code in Discord, and short `KEY=VALUE` pairs (like `NODE_ENV=debug`) are no longer incorrectly redacted. Follows up on #8287. ### Change type - [x] `improvement` ### Test plan 1. Trigger a deploy that includes secret env vars in error output 2. Verify Discord messages show `` `***` `` as inline code blocks instead of bare `***` (which Discord renders as bold) 3. Verify short env assignments like `LOG_LEVEL=debug` are not redacted ### Code changes | Section | LOC change | | -------------- | ---------- | | Config/tooling | +6 / -5 |
Closes #7572. In order to remove slow dual-linting and simplify the toolchain, this PR fully migrates the repo from ESLint + Prettier to Oxlint + Oxfmt, with workspace lint scripts executing Oxlint from the repo root for consistent config resolution. This removes the ESLint config and in-repo ESLint plugin setup, adds an Oxlint JS plugin for tldraw-specific rules, switches formatter commands and config to Oxfmt, and updates package/workspace scripts and CI to use the new stack end-to-end. ### After: Oxlint: ~6s Oxfmt: ~162ms ### Before: Eslint: ~1min 15s Prettier: ~4s ### Change type - [x] `improvement` ### Test plan 1. Run `yarn lint` from repo root. 2. Run `yarn lint` from a workspace (for example `packages/tldraw` and `apps/dotcom/client`) and verify it passes. 3. Run `yarn check-packages` and verify lint script expectations pass. 4. Run `yarn format-current` and `yarn lint-current` on changed files. - [ ] Unit tests - [ ] End to end tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )