Skip to content

[pull] main from remix-run:main #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 2 commits into from
Apr 22, 2026
Merged

[pull] main from remix-run:main #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f21e869
Remove temp restriction for change file workflow
brophdawg11 Apr 22, 2026
7a05510
Add links to comments
brophdawg11 Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/changes-file.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@ concurrency:
jobs:
check:
name: 📝 Change File Check
# TODO: Temporarily only run on my PRs for testing purposes
if: github.repository == 'remix-run/react-router' && github.event.pull_request.user.login == 'brophdawg11'
if: github.repository == 'remix-run/react-router'
runs-on: ubuntu-latest
permissions:
pull-requests: write
Expand Down
13 changes: 6 additions & 7 deletions scripts/changes/check-pr.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,23 +23,22 @@ const COMMENT_MARKER = "<!-- change-file-check -->";
const COMMENT_FOUND = `${COMMENT_MARKER}
### ✅ Change File Found

A \`.changes\` file has been found in this PR. Thanks!`;
A [change file](https://github.com/remix-run/react-router/blob/main/docs/community/contributing.md#change-files) file exists in this PR. Thanks!`;

const COMMENT_MISSING = `${COMMENT_MARKER}
### 📝 No Change File Found
### ⚠️ No Change File Found

This PR doesn't include a change file which is used for automated release notes.
If your change affects users, please add one (or more) and commit the generated file(s).
This PR doesn't include a [change file](https://github.com/remix-run/react-router/blob/main/docs/community/contributing.md#change-files) which is used for automated release notes.
If your change affects users, please add one (or more) change files and commit the generated file(s).

\`\`\`sh
pnpm run changes:add
\`\`\`

> This script requires Node 24+. If you are on a lower version, please [add a file manually](https://reactrouter.com/community/contributing#change-files)
> This script requires Node 24+. If you are on a lower version, please [add a file manually](https://github.com/remix-run/react-router/blob/main/docs/community/contributing.md#change-files)

> Not every PR needs a change file — you can skip this step if the change is internal-only
> (tests, tooling, docs)\
`;
> (tests, tooling, docs)`;

// Matches packages/*/.changes/*.md but not .gitkeep
const CHANGE_FILE_RE = /^packages\/[^/]+\/\.changes\/[^/]+\.md$/;
Expand Down
Loading