[pull] main from adobe:main#393
Merged
Merged
Conversation
…10076) * fix: normalize API diff so we dont pick up new formatting changes * forgot to run against test channel * debugging 401 * need to add models: read if we are setting contents: read? * Revert "forgot to run against test channel" This reverts commit b7fab94. * Revert "debugging 401" This reverts commit e691567.
Pins the default GITHUB_TOKEN to contents: read on the workflows in .github/workflows/ that don't call a GitHub API beyond the initial checkout. The other workflows in this directory are left implicit because they need write scopes that a maintainer is better placed to declare. Motivation: CVE-2025-30066 (March 2025 tj-actions/changed-files compromise) exfiltrated GITHUB_TOKEN from workflow logs. Per-workflow caps bound runtime authority irrespective of repo or org default, give drift protection if the default ever widens, and are credited per-file by the OpenSSF Scorecard Token-Permissions check. YAML validated locally with yaml.safe_load. Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
* fix headings levels in component decision tree * better illustration examples in SKILL.md * skip redirects in markdown output * fix stripped inline code from page descriptions in markdown output * fix S2 Routers rendering in markdown output * add dnd tag for RAC dnd docs page * improve Style Macro docs page markdown output * remove error pages from output * better JSDoc for focusRing (mention passing isFocusVisible) * improve skill with guidance on Buttons with icons and text * improve skill with guidance to avoid concatenating class names from the style macro * testing skill differ (#9947) * add skill differ * improve comment * deploy full diff + link to new/changed files * fix path * remove full diff output * comment with install links * format * fix formatting * skill improvements * more skill improvements * add figma-to-s2 resource * add creating-custom-components.md reference * reference new creating-custom-components.md elsewhere
…9848) * fix(GridLayout): support RTL direction for drop target positioning GridLayout.getDropTargetFromPoint() computes 'before'/'after' drop positions using x-coordinates, but has no awareness of layout direction. In RTL locales, the Virtualizer positions items using CSS 'right' with the layout rect's x value as the right-offset, while pointer coordinates remain in visual (left-origin) space. This mismatch causes drop targets to be inverted — dragging an item to the right of another shows a 'before' indicator instead of 'after'. This commit adds an optional 'direction' property to GridLayoutOptions. When set to 'rtl', getDropTargetFromPoint flips the x-coordinate to match the layout coordinate system before computing drop positions. Consumers can pass direction via useLayoutOptions() in a GridLayout subclass: class LocaleAwareGridLayout extends GridLayout { useLayoutOptions() { const { direction } = useLocale(); return { direction }; } } * test(GridLayout): add unit tests for RTL drop target positioning Tests getDropTargetFromPoint with both LTR and RTL directions to verify that drop targets (before/after) are computed correctly in multi-column grids. Also tests that single-column layouts are unaffected by direction and that empty layouts return a root drop target. * fix(GridLayout): auto-determine direction via useLocale() in RAC wrapper Instead of requiring consumers to subclass GridLayout and pass direction manually, create a RAC wrapper (like TableLayout) that calls useLocale() internally via useLayoutOptions(). The base layout in react-stately still accepts direction as an explicit option for non-RAC consumers. * fix: use public GridLayout import * add test story * fix tests, missing size mock * chore: apply oxfmt formatting Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix formatting --------- Co-authored-by: Daniel Lu <dl1644@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )