[pull] master from rrweb-io:master#42
Merged
Merged
Conversation
* Add asset event types Co-authored-by: Eoghan Murray <eoghan@getthere.ie>
* docs: design sandboxed rebuild guard * docs: refine sandboxed rebuild decision * docs: plan sandboxed rebuild implementation * fix(snapshot): guard unprotected browser rebuilds * test(snapshot): cover guarded rebuild targets * fix(snapshot): require iframe sandbox API * test(snapshot): reject raw sandbox attribute * feat(snapshot): add sandboxed iframe rebuild helper * test(snapshot): keep sandbox iframe mock test-local * fix(snapshot): clean up sandboxed iframe on rebuild failure * fix(snapshot): remove failed iframe from detached roots * test(snapshot): derive sandbox mock tokens from attribute * fix(rrweb): mark unsafe canvas rebuilds explicitly * test(rrweb): wait for unsafe canvas rebuild * test(rrweb): assert unsafe canvas rebuilt content * docs: explain sandboxed rebuild requirements * docs: clarify rebuild sandbox warnings * docs: add Chinese rebuild sandbox warning * docs: clarify sandbox rebuild target * chore: add sandboxed rebuild changeset * fix(snapshot): trust helper-created rebuild documents * fix(rrweb): use trusted sandboxed iframe factory * test(snapshot): cover trusted sandbox token policy * docs(snapshot): document rebuild options * fix(rrweb): keep unsafe rebuild state with iframe * fix(snapshot): reject detached sandbox roots * docs(snapshot): document sandboxed iframe helpers * Rename unsafe rebuild flags * Update sandboxed rebuild changeset
Prior problem: The rrweb-snapshot package contained both snapshot (record-time) and rebuild (replay-time) code. The rebuild module imports postcss, a large dependency that is only needed during replay. Because rrweb-snapshot was re-exporting everything from a single index.ts barrel file, bundlers that consume the pre-built package were not able to tree-shake out rebuild.ts and its postcss import, even when only snapshot functions were used. This PR is a reimplementation of #1784 and updates tests to expect record bundles to be within certain size parameters. #1784 was Authored by Eoghan Murray <eoghan@rrweb.com> and contained input from ClaudeAI #1837 (this) was also co-authored by Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )