[pull] master from rrweb-io:master#48
Merged
Merged
Conversation
* Ship @rrweb/all style css * Assert @rrweb/all style artifact in test
* Update docs for rrweb CDN * Apply formatting changes * Apply suggestion from @Juice10
…ari (#1854) * Add webkit only test to show how monkeypatching fails in Safari - necessitates a new CI environment * Add packages/rrweb/test/record/monkey-patched.test.ts to properly test the MutationObserver failure in webkit, and recognize that these tests can be run against any engine, not just webkit * Provide a fix for Safari for the iframe MutationObserver problem: - for Safari, we need to keep around the iframe for the duration of the recording, as a detached iframe cannot observe the main document in that browser (see https://webkit.org/b/179224 ) - we could extend this tweak to all browsers for simplicity and future proofing, but I'd prefer not to have an extra iframe polluting the DOM if not needed - have labelled the iframe with an __rrwebUntaintedMutationObserver attribute so anyone encountering it can debug it's purpose - the long lived iframe itself should not be recorded in a snapshot, so add an .rr-block class * Add changeset * Apply formatting changes * Forgot these files * Bump playwright version; this is the one that comes with the Docker images in any case * Missed some more files * Reuse rrweb test helpers --------- Co-authored-by: eoghanmurray <eoghanmurray@users.noreply.github.com> Co-authored-by: Justin Halsall <Juice10@users.noreply.github.com>
* Move root changelog notes to rrweb package * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )