[pull] main from ueberdosis:main#161
Merged
Merged
Conversation
…g during mid-update renders
…during mid-update renders
AllSelection.map() returns another AllSelection, so deleting it (e.g. after Ctrl/Cmd+A) left a whole-document range over the emptied doc instead of a cursor, showing a phantom selection highlight. deleteSelection now collapses any surviving non-empty selection to a text cursor. Fixes #7961
* Revert "test(ReactNodeViewRenderer): add test for getPos returning undefined during mid-update renders" This reverts commit 6a33b7b. * Revert "fix(NodeView): update getPos() to return undefined instead of throwing during mid-update renders" This reverts commit ddd43a8. * Revert "fix(vitest.config): change jsxImportSource from '@tiptap/core' to 'react'" This reverts commit 674a7bf.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )